apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH]: FreeBSD ports devel/apr
Date Wed, 09 Apr 2008 17:54:55 GMT
On Tue, Apr 08, 2008 at 01:51:19PM -0400, Philip M. Gollucci wrote:
> I'm sending this patch upstream, apr is one of the projects I don't have a 
> commit bit too, so please review commit, and MFC as needed.

That code should be using LDFLAGS rather than LIBS, and it should be 
adding to, rather than overwriting, both the variables.  Can you try 
this instead?

Index: build/dbm.m4
===================================================================
--- build/dbm.m4	(revision 646297)
+++ build/dbm.m4	(working copy)
@@ -671,8 +671,10 @@
     elif test "$withval" = "no"; then
       apu_have_gdbm=0
     else
-      CPPFLAGS="-I$withval/include"
-      LIBS="-L$withval/lib "
+      saved_cppflags="$CPPFLAGS"
+      saved_ldflags="$LDFLAGS"
+      CPPFLAGS="$CPPFLAGS -I$withval/include"
+      LDFLAGS="$LDFLAGS -L$withval/lib "
 
       AC_MSG_CHECKING(checking for gdbm in $withval)
       AC_CHECK_HEADER(gdbm.h, AC_CHECK_LIB(gdbm, gdbm_open, [apu_have_gdbm=1]))
@@ -680,6 +682,8 @@
         APR_ADDTO(APRUTIL_LDFLAGS, [-L$withval/lib])
         APR_ADDTO(APRUTIL_INCLUDES, [-I$withval/include])
       fi
+      CPPFLAGS="$saved_cppflags"
+      LDFLAGS="$saved_ldflags"
     fi
   ])
 

Mime
View raw message