From dev-return-19754-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Feb 12 21:11:03 2008
Return-Path: <dev-return-19754-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 90885 invoked from network); 12 Feb 2008 21:11:02 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 12 Feb 2008 21:11:02 -0000
Received: (qmail 78637 invoked by uid 500); 12 Feb 2008 21:10:55 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 78591 invoked by uid 500); 12 Feb 2008 21:10:55 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Id: <dev.apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 78579 invoked by uid 99); 12 Feb 2008 21:10:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 13:10:55 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [209.133.199.10] (HELO jimsys.jaguNET.com) (209.133.199.10)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 21:10:24 +0000
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by jimsys.jaguNET.com (Postfix) with ESMTP id 66D056E65E9;
	Tue, 12 Feb 2008 16:10:32 -0500 (EST)
Cc: APR Developer List <dev@apr.apache.org>
Message-Id: <1C6B61FC-A8CF-40F2-8087-299D8B924F07@jaguNET.com>
From: Jim Jagielski <jim@jaguNET.com>
To: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>,
 Basant Kukreja <Basant.Kukreja@sun.com>
In-Reply-To: <acf3f2e60802121218r6830b417t4d9030d316ab3e39@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Subject: Re: apr_pollset_poll return value (APR_EINTR) on solaris
Date: Tue, 12 Feb 2008 16:10:32 -0500
References: <20080212193226.GC4037@lbasantk3.red.iplanet.com> <acf3f2e60802121218r6830b417t4d9030d316ab3e39@mail.gmail.com>
X-Mailer: Apple Mail (2.919.2)
X-Virus-Checked: Checked by ClamAV on apache.org


On Feb 12, 2008, at 3:18 PM, Lucian Adrian Grijincu wrote:

> This is the code in question.
>
>    if (ret == -1) {
>        (*num) = 0;
>        if (errno == ETIME || errno == EINTR) {
>            rv = APR_TIMEUP;
>        }
>        else {
>            rv = APR_EGENERAL;
>        }
>    }
>
> I don't really like the APR_EGENERAL in the else either.
> Shouldn't this be something like:
> if (ret == -1)
> {
>   (*num) = 0;
>   rv = apr_get_netos_error();
> }
>
> and let apr_get_netos_error handle OS to APR errors consistent with
> other architectures (select.c, poll.c)
>

+1

Basant, can you confirm this works as expected?