apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c
Date Sun, 24 Feb 2008 20:48:24 GMT


On 02/24/2008 06:13 PM, William A. Rowe, Jr. wrote:
> rpluem@apache.org wrote:
>> -    apr_size_t written;
>> +    int written;
> 
> FYI - int is < apr_ssize_t, please flip that to a signed representation
> that corresponds to sizeof(void*)

Sorry that I don't get it but

- apr_vformatter returns an 'int'
- we only use 'written' later on to compare it against -1. Nothing else
   is done with 'written' afterwards.

So where is the point in using a signed representation that corresponds to
sizeof(void*)?

Regards

RĂ¼diger


Mime
View raw message