apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: proc_mutex recovery backport needed?
Date Thu, 28 Feb 2008 13:49:10 GMT
On Wed, Feb 27, 2008 at 01:54:34PM -0500, Eric Covener wrote:
> In trunk, locks/unix/proc_mutex.c has:
> 
> #ifdef HAVE_PTHREAD_MUTEX_ROBUST
>         /* Okay, our owner died.  Let's try to make it consistent again. */
>         if (rv == EOWNERDEAD) {
>             pthread_mutex_consistent_np(mutex->pthread_interproc);
>         }
> 
> In 1.2.x it is protected by a different macro:
> 
> #ifdef HAVE_PTHREAD_MUTEXATTR_SETROBUST_NP
>         /* Okay, our owner died.  Let's try to make it consistent again. */
>         if (rv == EOWNERDEAD) {
>             pthread_mutex_consistent_np(mutex->pthread_interproc);
>         }
>         else
> 
> The macro referenced by the 1.2.x code is not settable via APR
> autoconf and becomes dead code.

Nice catch!  Looks like I missed this originally then quietly snuck the 
fix into r385523 on the trunk - a double screw-up :) Fixed in r631971.

joe

Mime
View raw message