Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 20783 invoked from network); 11 Dec 2007 11:45:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Dec 2007 11:45:50 -0000 Received: (qmail 66102 invoked by uid 500); 11 Dec 2007 11:45:38 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 66044 invoked by uid 500); 11 Dec 2007 11:45:38 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 66033 invoked by uid 99); 11 Dec 2007 11:45:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2007 03:45:38 -0800 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 11 Dec 2007 11:45:16 +0000 Received: (qmail 2570 invoked from network); 11 Dec 2007 12:45:15 +0100 X-Remote-IP: 213.191.142.123 Received: from unknown (HELO mx.iskon.hr) (213.191.142.123) by mxout2.iskon.hr with SMTP; 11 Dec 2007 12:45:15 +0100 Received: (qmail 19181 invoked from network); 11 Dec 2007 12:45:15 +0100 X-AVScan: ClamAV X-Remote-IP: 89.164.16.84 Received: from 16-84.dsl.iskon.hr (HELO ?192.168.0.168?) (89.164.16.84) by mx.iskon.hr with SMTP; 11 Dec 2007 12:45:15 +0100 Message-ID: <475E784D.2030309@apache.org> Date: Tue, 11 Dec 2007 12:45:17 +0100 From: Mladen Turk User-Agent: Mozilla MIME-Version: 1.0 To: APR Developer List Subject: Failing apr_pool_create in case apr_pools_initialized == 0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi, I'd like to make sure the apr_pool_create(_ex) returns error in case apr was terminated, meaning apr_pool_terminate() was called and apr_pools_initialized is 0. Seems we are missing that check in apr_pool_create_ex, and I think APR_ENOMEM is correct error code we could return in that case (or perhaps APR_EINVAL) Comments? Regards, Mladen