From dev-return-19652-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Dec 21 09:53:08 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 56821 invoked from network); 21 Dec 2007 09:53:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Dec 2007 09:53:08 -0000 Received: (qmail 35743 invoked by uid 500); 21 Dec 2007 09:52:57 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 35694 invoked by uid 500); 21 Dec 2007 09:52:57 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 35679 invoked by uid 99); 21 Dec 2007 09:52:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2007 01:52:57 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of michael@metaparadigm.com designates 203.117.131.43 as permitted sender) Received: from [203.117.131.43] (HELO metamail-vm.metaparadigm.com) (203.117.131.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2007 09:52:34 +0000 Received: from [10.1.0.60] (monty-eth0.metaparadigm.com [10.1.0.60]) (authenticated bits=0) by metamail-vm.metaparadigm.com (8.13.8/8.13.8/Debian-3) with ESMTP id lBL9qOCA012332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Dec 2007 17:52:35 +0800 Message-ID: <476B8CD9.8060808@metaparadigm.com> Date: Fri, 21 Dec 2007 17:52:25 +0800 From: Michael Clark Organization: Metaparadigm Pte Ltd User-Agent: Mozilla-Thunderbird 2.0.0.6 (X11/20071009) MIME-Version: 1.0 To: Davi Arnaut CC: dev@apr.apache.org Subject: Re: Extended Attributes Support References: <4769F773.10503@metaparadigm.com> <476B760F.8070807@apache.org> In-Reply-To: <476B760F.8070807@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.90.1/5203/Fri Dec 21 12:10:12 2007 on metamail-vm X-Virus-Status: Clean X-Virus-Checked: Checked by ClamAV on apache.org Davi Arnaut wrote: > I prefer a new apr_file_xattr.h header. > OK. I'll do this. >> I have all the unix implementations rolled into one file >> (file_io/unix/xattr.c) with many #if's. Should I perhaps have >> a linux.c, darwin.c, freebsd.c, solaris.c in a subdirectory? >> Not sure how I would integrate this into the build (perhaps >> having a single #if that create empty compilation units for >> the inactive platforms?). >> > > Hum, I tend to prefer separate separate files having the #if to empty, > maybe in file_io/unix/xattr/ subdirectory. You can also put internal > headers in include/arch/... > OK. That is what I thought and had done this in the patches (although it is not yet in a subdirectory). I had them in file_io/unix/xattr/ they were not picked up by buildconfig and I wasn't sure where to tune this? > Auto detected, with a configure option to disable (--disable-xattrs). > OK. I will add a disable option. > s/specificed/specified/ > Picked this one up since. thanks. > s/filepath/file path/ > OK. > apr_uint32_t flags > This was a case of following what was in apr_file_info.h for the other interfaces with a flags argument. >> * @param filepath the full path to the file >> * @param name the attribute name to get >> * @param value the returned attribute value, if value is NULL then only >> * the size of the attribute value is returned >> > > Would be nice to have some kind of option to allocate from the pool, > otherwise it doesn't make much sense to pass void **. > It does allocate. I will make this more clear in the docs. Perhaps I can ditch the size only mode and not allow NULL? (it'll allow removing a couple of lines) I'll go through all of this feedback, add an issue to bugzilla and run up another patch set. Thanks much.