apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: Extended Attributes Support
Date Fri, 21 Dec 2007 21:24:31 GMT
Michael Clark wrote:
> I have been doing some work on implementing extended attributes
> support for apr.

Cool beans.

> Not implemented:
> * Windows - should be able to use named :streams (similar to Solaris)

Actually you have streams, and you have ntfs EA's.  They are actually
different beasts, AIUI.

> I have some questions on build structure...
> Should I put the declarations in apr_file_info.h or would it be
> better to add a apr_file_xattr.h header?

I'd suggest a new header (it can include apr_file_info for itself)
to keep things simple, if this api proves to grow.

> I have all the unix implementations rolled into one file
> (file_io/unix/xattr.c) with many #if's. Should I perhaps have
> a linux.c, darwin.c, freebsd.c, solaris.c in a subdirectory?

Well, I've been in the sendfile implementation.  It's not pretty.

I'd go for a subdir option (xattrs/solaris.c, xattrs/freebsd.c, etc)
where the parent apr_xattrs.c in the unix directory just sucks in
the correct implementation by ifdef tests...

> Not sure how I would integrate this into the build (perhaps
> having a single #if that create empty compilation units for
> the inactive platforms?).

the last #else case in apr_xattrs.c falls into APR_ENOTIMPL stubs.

> Test cases should go into a new unit - not linked into testall?

yes linked in.  APR_ENOTIMPL just isn't a fail-case.

> Also what is the procedure for proposing and adding a new API like
> this. I guess my patch should have it disabled by default and enabled
> with a configure flag - say --enable-xattrs (or autodetected and enabled
> on supported platforms)?

Nope - just enable it; this is on trunk so we have some time to get
things right.  When folks deploy conditional features it makes it
a total nightmare for the next package which shares the libs.

View raw message