apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r602176 - /apr/apr/trunk/network_io/unix/sockaddr.c
Date Mon, 10 Dec 2007 21:58:41 GMT
On Mon, Dec 10, 2007 at 03:20:18PM -0600, William Rowe wrote:
> Joe Orton wrote:
>> Either way, trying to work around that with an APR resolver hack seems 
>> completely wrong, -1, it will propagate v4-mapped IPv6 addresses when none 
>> are necessary, that may very well break/confuse other callers.
>
> Howso?  The user explicitly passes an IPv4 address and requests an IPv6
> flavor sa.

No, you've changed the behaviour for *every* family==AF_INET6 lookup 
whether that's for "www.google.com" or an IPv4 dotted quad.  Previously 
such lookups would fail where the hostname had no v6 address associated; 
now, where there is a v4 address associated, they will always succeed 
and give out the v4-mapped IPv6 address.

The previous behaviour makes far more sense, and it would not be 
unreasonable for applications to rely on it.  In fact it looks like the 
APR_IPV6_ADDR_OK flag is exactly a case which relies on that behaviour, 
and is now presumably broken.

joe

Mime
View raw message