apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: svn commit: r602176 - /apr/apr/trunk/network_io/unix/sockaddr.c
Date Mon, 10 Dec 2007 21:24:25 GMT
On Mon, Dec 10, 2007 at 02:39:19PM -0600, William A. Rowe, Jr. wrote:
> Jump into the ftp_cmd_eprt function...

yeah, this is as awkward case that does go through a text-lookup :( The
patch makes sense for that case, but it still feels a bit strange
putting it in APR.  

> Now; are you suggesting that it would be more efficient and effective
> if we cloned the local_addr structure, modified the port and directly
> used the clone to apr_socket_bind rather than going through these extra
> apr_sockaddr_info_get gymnastics?
> 
> If so, what is the proper method to clone an sa in the apr schema?

Hmm, we should probably look modifying apr_sockaddr_vars_set or adding a
call for resetting the port to zero reliably.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message