From dev-return-19411-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Nov 16 00:49:05 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 55490 invoked from network); 16 Nov 2007 00:49:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Nov 2007 00:49:04 -0000 Received: (qmail 9843 invoked by uid 500); 16 Nov 2007 00:48:51 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 9788 invoked by uid 500); 16 Nov 2007 00:48:51 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 9777 invoked by uid 99); 16 Nov 2007 00:48:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2007 16:48:51 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of bojan@rexursive.com designates 203.171.74.242 as permitted sender) Received: from [203.171.74.242] (HELO beauty.rexursive.com) (203.171.74.242) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Nov 2007 00:48:40 +0000 Received: by beauty.rexursive.com (Postfix, from userid 48) id E5CFA40391; Fri, 16 Nov 2007 11:48:31 +1100 (EST) Received: from CitistreetAustPtyLtd.52GDC76F02.optus.net.au (CitistreetAustPtyLtd.52GDC76F02.optus.net.au [202.139.144.26]) by www.rexursive.com (Horde MIME library) with HTTP; Fri, 16 Nov 2007 11:48:31 +1100 Message-ID: <20071116114831.slycxoudscwk8gk0@www.rexursive.com> Date: Fri, 16 Nov 2007 11:48:31 +1100 From: Bojan Smojver To: "Paul J. Reder" Cc: "APR dev list." Subject: Re: [Patch]: Add basic function to APR for LDAP rebind callback support. References: <473B9AA3.3070005@remulak.net> <1195091090.2540.51.camel@shrek.rexursive.com> <473CBF8B.3040903@remulak.net> In-Reply-To: <473CBF8B.3040903@remulak.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) X-Virus-Checked: Checked by ClamAV on apache.org Quoting "Paul J. Reder" : > The patches have been updated to address the issues pointed > out below (thanks Bojan). > > New contents at the old links: > http://people.apache.org/~rederpj/APR-trunk_rebind.diff > http://people.apache.org/~rederpj/Apache-trunk_rebind.diff Cool. > Question: To what end? The xref entry isn't of any use to anyone except > in terms of a node in a list that the rebind callback can scan through. > The problem is that the rebind callback function is called from the ldap > library function and has no context related to the original request info > other than the ldap handle passed to it. The xrefs and the list they are > kept in needs to be protected to avoid concurrency issues, and having the > xref pointer doesn't help the rebind callback function since the xref > pointer can't be passed to it. Is there some reason the xref entry would > be of use to the caller that I've not thought of? Point taken. I didn't actually look into what the patch does when I =20 reviewed the code. --=20 Bojan