apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucian Adrian Grijincu" <lucian.griji...@gmail.com>
Subject Re: svn commit: r592305 - /apr/apr/trunk/test/testlfs.c
Date Tue, 06 Nov 2007 08:51:53 GMT
On Nov 6, 2007 8:34 AM,  <wrowe@apache.org> wrote:
> Author: wrowe
> Date: Mon Nov  5 22:34:18 2007
> New Revision: 592305
>
> URL: http://svn.apache.org/viewvc?rev=592305&view=rev
> Log:
> On some (bogus) platforms we can only discover csize-by-name.
> Ask for it, either way.
>

Would you be so kind as to point out which platforms?

> Modified:
>     apr/apr/trunk/test/testlfs.c
>
> Modified: apr/apr/trunk/test/testlfs.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/test/testlfs.c?rev=592305&r1=592304&r2=592305&view=diff
> ==============================================================================
> --- apr/apr/trunk/test/testlfs.c (original)
> +++ apr/apr/trunk/test/testlfs.c Mon Nov  5 22:34:18 2007
> @@ -66,6 +66,8 @@
>
>      if (rv == APR_SUCCESS) {
>          rv = apr_file_info_get(&testsize, APR_FINFO_CSIZE, f);
> +        if (rv == APR_INCOMPLETE)
> +            rv = apr_stat(&testsize, TESTFN, APR_FINFO_CSIZE, p);
>      }

shouldn't this be inside APR code for apr_file_info_get?
if it failed using today's code, it should run code from apr_stat to
try and determine the file size, shouldn't it?


>
>      /* give up if we can't determine the allocation size of the file,
>
>
>



-- 
Lucian

Mime
View raw message