apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [Patch]: Add basic function to APR for LDAP rebind callback support.
Date Fri, 16 Nov 2007 00:48:31 GMT
Quoting "Paul J. Reder" <rederpj@remulak.net>:

> The patches have been updated to address the issues pointed
> out below (thanks Bojan).
> New contents at the old links:
> http://people.apache.org/~rederpj/APR-trunk_rebind.diff
> http://people.apache.org/~rederpj/Apache-trunk_rebind.diff


> Question: To what end? The xref entry isn't of any use to anyone except
> in terms of a node in a list that the rebind callback can scan through.
> The problem is that the rebind callback function is called from the ldap
> library function and has no context related to the original request info
> other than the ldap handle passed to it. The xrefs and the list they are
> kept in needs to be protected to avoid concurrency issues, and having the
> xref pointer doesn't help the rebind callback function since the xref
> pointer can't be passed to it. Is there some reason the xref entry would
> be of use to the caller that I've not thought of?

Point taken. I didn't actually look into what the patch does when I  
reviewed the code.


View raw message