apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [Patch]: Add basic function to APR for LDAP rebind callback support.
Date Thu, 15 Nov 2007 01:44:50 GMT
On Wed, 2007-11-14 at 20:02 -0500, Paul J. Reder wrote:

> The APR portion of the patch:
> http://people.apache.org/~rederpj/APR-trunk_rebind.diff

Just a few comments (without going into what the patch does):

- you probably want to rename apr_ldap_init_xref_lock() to
apr_ldap_xref_init() instead

- LDAP_rebindproc() should probably be static

- what happens when apr_ldap_xref_init() gets called again (e.g. by
another Apache module wanting to initialise this subsystem)?

- is it possible to make the API so that xref entry is returned instead
of being stored for the process?

- LDAP_xref_entry_t live is a namespace violation, because it's in a
public header file; should probably be called apr_ldap_xref_entry_t


View raw message