Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of lucian.grijincu@gmail.com
 designates 72.14.246.242 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=mUCzVnsh0OIYtLSLXDQCOmm28o5DdOFvWqlmHntbkTHt6cTKdOC5FkUz6FdgmSYys1AVf/rHsAKcWcJs2YR1Xw3B7RE8hO3IABpfJFqvORQrzdREDMhJZcWBRIWQ9S6IASBW4ZGTdQINIujEiIZwFudBlZeoL8jMJM6auLGq7QA=
Message-ID: <acf3f2e60710140504w4f63d24eqcec06c70749854d8@mail.gmail.com>
Date: Sun, 14 Oct 2007 15:04:21 +0300
From: "Lucian Adrian Grijincu" <lucian.grijincu@gmail.com>
To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: some simplifications for the Netware apr_thread_create code
Cc: "APR Developer List" <dev@apr.apache.org>
In-Reply-To: <47116F6A.90709@rowe-clan.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <acf3f2e60710131816h3aa43542sa898a159ac206cdf@mail.gmail.com>
	 <47116F6A.90709@rowe-clan.net>

On 10/14/07, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> Lucian Adrian Grijincu wrote:
> > Just removing some unused code.
> > APR_SUCCESS is deemed to be zero as I understand it, so no use in
> > checking for it explicitly.
>
> Untrue, because it makes things clearer to the reader.
>

isn't this why they invented comments?

why do:

   if(x==0)
     return 0;
   return x;

when you can do:
   return x; //and place a witty comment here?

saves a cmp and a jump.

> The compiler can't care less if you compare (rv == 0) or (!rv),
> it optimizes it the same way.
>

What !rv? i don't wanna do the comparison at all.

--
Lucian