Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 51582 invoked from network); 16 Oct 2007 15:16:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Oct 2007 15:16:06 -0000 Received: (qmail 93713 invoked by uid 500); 16 Oct 2007 15:15:53 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 93653 invoked by uid 500); 16 Oct 2007 15:15:52 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 93642 invoked by uid 99); 16 Oct 2007 15:15:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2007 08:15:52 -0700 X-ASF-Spam-Status: No, hits=-4.0 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2007 15:15:56 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l9GFDXpG026507 for ; Tue, 16 Oct 2007 11:13:33 -0400 Received: from turnip.manyfish.co.uk (IDENT:U2FsdGVkX18LTiutReGZiaLsa9Q3389gpIluR+muoZw@vpn-14-36.rdu.redhat.com [10.11.14.36]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9GFDWaN013335 for ; Tue, 16 Oct 2007 11:13:32 -0400 Received: from jorton by turnip.manyfish.co.uk with local (Exim 4.66) (envelope-from ) id 1IhneL-00073d-4B for dev@apr.apache.org; Tue, 16 Oct 2007 15:44:01 +0100 Date: Tue, 16 Oct 2007 15:44:01 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: svn commit: r584889 - in /apr/apr/branches/1.2.x: CHANGES include/apr_network_io.h network_io/unix/sendrecv.c network_io/win32/sendrecv.c test/testsockets.c Message-ID: <20071016144400.GA26952@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <20071015201617.B0FCD1A983A@eris.apache.org> <4713CC74.7020707@rowe-clan.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4713CC74.7020707@rowe-clan.net> User-Agent: Mutt/1.5.14 (2007-02-12) Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Oct 15, 2007 at 03:24:20PM -0500, William Rowe wrote: > wrowe@apache.org wrote: > >Author: wrowe > >Date: Mon Oct 15 13:16:15 2007 > >New Revision: 584889 > > > >URL: http://svn.apache.org/viewvc?rev=584889&view=rev > > Joe - is this commit satisfactory? I saw little reason to back out the > other > improvements to testsockets.c I had already made for error reviewability. Yup, looks good here. joe