William A. Rowe, Jr. wrote: > Lucian Adrian Grijincu wrote: >> Just removing some unused code. >> APR_SUCCESS is deemed to be zero as I understand it, so no use in >> checking for it explicitly. > > Untrue, because it makes things clearer to the reader. > > The compiler can't care less if you compare (rv == 0) or (!rv), > it optimizes it the same way. It doesn't matter anyways - those aren't apr_ functions, their value of zero is particular to Netware semantics.