From dev-return-19122-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Oct 12 15:16:33 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 72815 invoked from network); 12 Oct 2007 15:16:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Oct 2007 15:16:32 -0000 Received: (qmail 32071 invoked by uid 500); 12 Oct 2007 15:16:18 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 32017 invoked by uid 500); 12 Oct 2007 15:16:18 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 32006 invoked by uid 99); 12 Oct 2007 15:16:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2007 08:16:18 -0700 X-ASF-Spam-Status: No, hits=-4.0 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2007 15:16:22 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id l9CFDoBt023105 for ; Fri, 12 Oct 2007 11:13:50 -0400 Received: from turnip.manyfish.co.uk (IDENT:U2FsdGVkX1/L0OACulX0nJYBG2ARl6XniCmwfnX7KDo@vpn-14-154.rdu.redhat.com [10.11.14.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l9CFDmhw027261 for ; Fri, 12 Oct 2007 11:13:49 -0400 Received: from jorton by turnip.manyfish.co.uk with local (Exim 4.66) (envelope-from ) id 1IgM5x-0001w2-2q for dev@apr.apache.org; Fri, 12 Oct 2007 16:06:33 +0100 Date: Fri, 12 Oct 2007 16:06:33 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: Tagging 1.2.* Sat night or Sun a.m. Message-ID: <20071012150633.GA7324@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <470DD429.90908@rowe-clan.net> <470E3DD5.3060204@rowe-clan.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <470E3DD5.3060204@rowe-clan.net> User-Agent: Mutt/1.5.14 (2007-02-12) Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Brendan Lane (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Oct 11, 2007 at 10:14:29AM -0500, William Rowe wrote: > Lucian Adrian Grijincu wrote: > > > >Do my patches against configure.in, apr.hnw and apr.hw fixing the > >apr_ino_t ( http://issues.apache.org/bugzilla/show_bug.cgi?id=43417 ) > >issue have a chance of getting accepted (aka should I try to test them > >on other configurations to see whether they break something on some > >systems)? > > Not according to folks interpretation of our versioning policy, it seems > this patch must wait for 2.0.0. You would be breaking ABI for anyone > building against a 32 bit APR build. Lucian's patches do not change the ABI of the library which is built (at least by design, unless you are talking about some problem with the implementation which I'm missing). In the case where APR is built *without* _FILE_OFFSET_BITS=64, and an external application includes APR headers *with* _FILE_OFFSET_BITS=64 defined, an APR library ABI would be used by the application which does not match the real ABI, and all bets were off. Lucian's patch fixes that. Exposing apr_ino_t from apr.h rather than only from apr_file_info.h is certainly an API extension and so cannot be done in 1.2.x. joe