apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Trawick" <traw...@gmail.com>
Subject Re: svn commit: r583860 - in /apr/apr/branches/1.2.x: CHANGES threadproc/win32/proc.c
Date Thu, 11 Oct 2007 19:31:59 GMT
On 10/11/07, William A. Rowe, Jr. <wrowe@rowe-clan.net> wrote:
> trawick@apache.org wrote:
> >  Changes for APR 1.2.12
> >
> > +  *) apr_procattr_io_set() on Windows: Set pipe handles non-blocking as
> > +     appropriate based on the input parameters.  PR 43522.
> > +     [Eric Covener <covener gmail.com>]
>
> would it be less confusing to say;
>
>
> apr_procattr_io_set() on Windows: Set non-blocking pipe handles
> to a default timeout of 0, following the Unix default.  No effect
> on pipe handles configured to block.

brain freeze at the moment trying to think of alternatives

my concerns with some of your text:

setting timeouts to zero is an unnecessary detail since the
procattr_io_set API is in the simple terms of blocking or not

"Unix default" is really the expected portable behavior

the deal was that some pipe handles were supposed to be set
non-blocking, but they weren't

Mime
View raw message