apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lucian Adrian Grijincu" <lucian.griji...@gmail.com>
Subject Re: apr_thread_create on all platforms does unnecessary attributions
Date Sat, 13 Oct 2007 12:59:04 GMT
against trunk head.
make check (on Ubuntu 7.10)
All tests passed.


On 10/13/07, Lucian Adrian Grijincu <lucian.grijincu@gmail.com> wrote:
> On all platforms there is a
>      (*new)>pool=pool;
>
> followed closely by a
>     stat = apr_pool_create(&(*new)->pool, pool);
>
> Between these two, (*new)->pool is not used. I'd say the attribution
> is unnecessary and can be removed.
>
> Attached a patch (against 1.2.x head) that removes the unnecessary attribution.
> I'll follow up with a 1.3 trunk patch.
> (BTW, with this patch, all is well on Ubuntu 7.10. It builds and make
> checks cleanly).
>
> --
> Lucian
>
>

Mime
View raw message