apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: svn commit: r588062 - /apr/apr-util/trunk/buckets/apr_brigade.c
Date Thu, 25 Oct 2007 06:54:53 GMT
wrowe@apache.org wrote:
> Author: wrowe
> Date: Wed Oct 24 15:29:11 2007
> New Revision: 588062
> 
> URL: http://svn.apache.org/viewvc?rev=588062&view=rev
> Log:
> Adopt 1.3.0 trunk's new constant.
> 
> Modified:
>     apr/apr-util/trunk/buckets/apr_brigade.c
> 
> Modified: apr/apr-util/trunk/buckets/apr_brigade.c
> URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/buckets/apr_brigade.c?rev=588062&r1=588061&r2=588062&view=diff
> ==============================================================================
> --- apr/apr-util/trunk/buckets/apr_brigade.c (original)
> +++ apr/apr-util/trunk/buckets/apr_brigade.c Wed Oct 24 15:29:11 2007
> @@ -29,12 +29,6 @@
>  #include <sys/uio.h>
>  #endif
>  
> -/* TODO: ~((apr_size_t)0) appears to be the best way to quickly 
> - * represent  MAX_APR_SIZE_T for any CPU we support.  Move this
> - * out as APR_MAX_SIZE_T to our public headers...
> - */
> -#define MAX_APR_SIZE_T (~((apr_size_t)0))
> -
>  static apr_status_t brigade_cleanup(void *data) 
>  {
>      return apr_brigade_cleanup(data);
> @@ -123,7 +117,7 @@
>          /* For an unknown length bucket, while 'point' is beyond the possible
>           * size contained in apr_size_t, read and continue...
>           */
> -        if ((e->length == (apr_size_t)(-1)) && (point > MAX_APR_SIZE_T))
{
> +        if ((e->length == (apr_size_t)(-1)) && (point > APR_SIZE_MAX))
{
>              /* point is too far out to simply split this bucket,
>               * we must fix this bucket's size and keep going... */
>              rv = apr_bucket_read(e, &s, &len, APR_BLOCK_READ);
> 
> 
> 

That gives:
+++
make[1]: Entering directory `/home/jfclere/apr-util'
/bin/sh /home/jfclere/APR/build-1/libtool --silent --mode=compile gcc -g
-O2 -pthread   -DHAVE_CONFIG_H -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE
-D_LARGEFILE64_SOURCE   -I/home/jfclere/apr-util/include
-I/home/jfclere/apr-util/include/private
-I/home/jfclere/APR/include/apr-1  -I/usr/include/mysql  -o
buckets/apr_brigade.lo -c buckets/apr_brigade.c && touch
buckets/apr_brigade.lo
buckets/apr_brigade.c: In function 'apr_brigade_partition':
buckets/apr_brigade.c:120: error: 'APR_SIZE_MAX' undeclared (first use
in this function)
buckets/apr_brigade.c:120: error: (Each undeclared identifier is
reported only once
buckets/apr_brigade.c:120: error: for each function it appears in.)
make[1]: *** [buckets/apr_brigade.lo] Error 1
make[1]: Leaving directory `/home/jfclere/apr-util'
make: *** [all-recursive] Error 1
+++

Cheers

Jean-Frederic

Mime
View raw message