apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: apr_xml_parser_geterror()
Date Fri, 19 Oct 2007 20:03:14 GMT
Daniel May wrote:
> Should the function
> apr_xml_parser_geterror(apr_xml_parser *parser, char *errbuf, apr_size_t
> errbufsize)
> crash if apr_xml_parser *parser is not initialized ?  That is the case
> today.  From the examples, it is common to do the following:
> 
> 
>    rv = apr_xml_parse_file(pool, &parser, &doc, fd, 2000);
>    if (rv != APR_SUCCESS) 
>    {
>         fprintf(stderr, "APR Error %s\nXML Error: %s\n",
>                 apr_strerror(rv, errbuf, sizeof(errbuf)),
>              apr_xml_parser_geterror(parser, errbufXML,
> sizeof(errbufXML)));

It sounds like examples are wrong.

 >              !parser ? "Unknown" : apr_xml_parser_geterror(parser, errbufXML,

might help?  (Would solve even if we decide this is something to fix, for users
bound to older apr-util's.)


Mime
View raw message