apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <li...@holsman.net>
Subject Re: [PATCH] apr_dbd_mysql.c
Date Fri, 19 Oct 2007 04:52:27 GMT


Bojan Smojver wrote:
> On Fri, 2007-10-19 at 12:31 +1000, Ian Holsman wrote:
>
>   
>>          {"flags", NULL},
>> +        {"multi", NULL},
>>     
>
> Shouldn't this be part of "flags"?
>
>   
yes.. this was just me being lazy on our internal one. we needed multi 
statement support for sprocs, but for this discussion it is irrelevant.

>
>>      if(real_conn == NULL) {
>> +        const char* errstring;
>> +        errstring =mysql_error(sql->conn);
>> +        fprintf(stderr, "%s\n",errstring);
>>     
>
> I'm guessing the above is your private debugging stuff, right?
>   

yes thats' debugging, but it would be nice to be able to return the 
error message when it fails to connect. the 'close' after the real_open 
removes the error so all you get is the internal error code.
>   
>> @@ -1582,6 +1598,8 @@
>>  static void dbd_mysql_init(apr_pool_t *pool)
>>  {
>>      my_init();
>> +    mysql_thread_init();
>>     
>
> Although I can't see any segfaults on Fedora without this, having it in
> doesn't upset it either. So, I think we should commit that.
>
>   
interesting, on OS/X it gets one every time, even running it with -X. 
(when i specify the groups=xyz in the DBDParam setting)

--Ian


Mime
View raw message