apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r589910 - in /apr/apr/trunk: CHANGES configure.in
Date Tue, 30 Oct 2007 08:54:45 GMT
On Mon, Oct 29, 2007 at 07:14:45PM -0500, William Rowe wrote:
> Before I backport, I want to quickly test the temperature of the list...
> 
> wrowe@apache.org wrote:
> >URL: http://svn.apache.org/viewvc?rev=589910&view=rev
> >Log:
...
> 
> >--- apr/apr/trunk/configure.in (original)
> >+++ apr/apr/trunk/configure.in Mon Oct 29 16:32:59 2007
> >@@ -1413,6 +1413,10 @@
> >     # Enable LFS
> >     aprlfs=1
> >     AC_CHECK_FUNCS([mmap64 sendfile64 sendfilev64 mkstemp64 readdir64_r])
> >+elif test "${ac_cv_sizeof_off_t}" != "${ac_cv_sizeof_size_t}"; then
> >+    # unsure of using -gt above is as portable, can can't forsee where
> >+    # off_t can legitimately be smaller than size_t
> >+    aprlfs=1
> > else
> 
> are we ok with this implementation or do folks have better ideas?

This will break at least mod_perl, I don't see how it's a good idea, or 
why it's even necessary.  Why change it?  Just so some tests run on more 
platforms?  That is achievable by tweaking some #defines in testlfs.c.

APR_HAS_LARGE_FILES has meant on Unix for the lifetime of 1.x "apr_off_t 
larger than native off_t".

joe

Mime
View raw message