apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject Re: [PATCH] apr_dbd_mysql.c
Date Fri, 19 Oct 2007 03:16:47 GMT
On Fri, 2007-10-19 at 12:31 +1000, Ian Holsman wrote:

>          {"flags", NULL},
> +        {"multi", NULL},

Shouldn't this be part of "flags"?

+    if (fields[8].value != NULL) {
>          sql->fldsz = atol(fields[7].value);

The above line should also be patched (i.e. this is now index 8, not 7).

>      if(real_conn == NULL) {
> +        const char* errstring;
> +        errstring =mysql_error(sql->conn);
> +        fprintf(stderr, "%s\n",errstring);

I'm guessing the above is your private debugging stuff, right?

> @@ -1582,6 +1598,8 @@
>  static void dbd_mysql_init(apr_pool_t *pool)
>  {
>      my_init();
> +    mysql_thread_init();

Although I can't see any segfaults on Fedora without this, having it in
doesn't upset it either. So, I think we should commit that.

-- 
Bojan


Mime
View raw message