From dev-return-18965-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Sun Sep 16 14:55:33 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 64006 invoked from network); 16 Sep 2007 14:55:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Sep 2007 14:55:31 -0000 Received: (qmail 81325 invoked by uid 500); 16 Sep 2007 14:55:22 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 81282 invoked by uid 500); 16 Sep 2007 14:55:22 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Delivered-To: moderator for dev@apr.apache.org Received: (qmail 79266 invoked by uid 99); 16 Sep 2007 14:52:04 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of gringocroco@gmail.com designates 209.85.146.176 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:reply-to:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=C0LN8jvBVSHU5XHSmSdv0wnX4xTmNH9SdUF0lEvD5xM=; b=lo8Xku8/4fFTbDc+4BQd6u9iyG/w5gCVkIwtMB8C9/eTWjkXMO4u9Y9UwyqcveSCPh9/EwoDUryM9WaFJ/OlKSqqr+AO6l9kJczFKQM3BDJ9dCxWmATOWdehZARpDDsUHKKYxUKHqQisAfP7pUY52oPz2ze2E1QGnyZkJOJGjdQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:reply-to:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=tezBJaHWNeF6YJTGGtVFbpVq+1hPTWMwLfYnwhjP9NKJ8NW7Fs/0OywjswPJk4BI6N9HDAexHpWKkvucFlN+WVXxdijjma5EQE/oLMsHLmSWrZhP0L67CrdbLX1npRr+nNdLYXdUXhFmldTNEgVQz/pyjIcTFTc7AAF+vijESAg= Message-ID: <4d45da050709160751m5cb03c8cs921f3503c70e1e01@mail.gmail.com> Date: Sun, 16 Sep 2007 17:51:39 +0300 From: "Lucian Adrian Grijincu" Reply-To: lucian.grijincu@gmail.com Sender: gringocroco@gmail.com To: "Peter Samuelson" Subject: Re: _FILE_OFFSET_BITS=64 _LARGEFILE_SOURCE undefined when LFS enabled Cc: dev@apr.apache.org In-Reply-To: <20070213211139.GA17862@p12n.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45AE3A3B.9040206@avira.com> <20070213211139.GA17862@p12n.org> X-Google-Sender-Auth: c5bbee7958e12fd4 X-Virus-Checked: Checked by ClamAV on apache.org Currently APR still uses ino_t in apr_file_info.h in trunk: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr_file_info.h?view=markup and compiling with _FILE_OFFSET_BITS=64 will change the ABI: sizeof(apr_ino_t) == sizeof(ino_t) == 4 or 8 depending on the compile time flags. Removing the dependency on the ino_t and using Peter's patch will preserve ABI regardless of _FILE_OFFSET_BITS=64 being defined or not. Is this not considered a bug of the header files? -- Lucian Adrian Grijincu On 2/14/07, Peter Samuelson wrote: > > [sorry for late reply, I'm catching up a bit on old list mail] > > [Lucian Adrian Grijincu] > > apr_dir_read puts the returned data in and apr_finfo_t structure, which > > has an apr_ino_t field. This field is 4 or 8 bytes in size dependent on > > _FILE_OFFSET_BITS=64 being either undefined or defined. > > Indeed - but forcing every apr-using application to also use LFS is not > optimal either. > > We ran into this issue in Debian, and kludged it by patching > apr_file_info.h not to use ino_t at all, but instead 'unsigned int' or > 'unsigned long' depending on platform. I also added a build-time test > to ensure we're using the same field size on each platform that we did > before the patch, so as not to change our ABI (so apps did not need to > be recompiled). > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFF0imLXk7sIRPQRh0RApMDAJoCnvyRlxsR2SRaHOjwOOIC05BCmwCeKd9v > /ZhhYgQVmW71UffTned5xWc= > =z8Gf > -----END PGP SIGNATURE----- > > >