apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <mar...@apache.org>
Subject Re: PATCH: md5 hash files not portable between EBCDIC and ASCII
Date Fri, 07 Sep 2007 09:05:07 GMT
On Thu, Sep 06, 2007 at 07:41:50PM -0400, David Jones wrote:
> There does not appear to be any installed EBCDIC base that would require a
> compatability option to generate the current hash.
> (These changes do not affect the hash created on ASCII in anyway)
> 
> patch does following:
> 
> 1) The context->xlate field needs to be initialized in both contexts for the
> apr_xlate_conv_buffer to occur.
> 2) the apr_xlate_conv_buffer needs to be skipped not just for apr_md5_final
> as is done now,
>     but also when final is passed into apr_md5_update.

+1, verified to work for httpd-2.2.6 + apr-util-1.2.10

   Martin 
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>        |     Fujitsu Siemens
http://www.fujitsu-siemens.com/imprint.html | 81730  Munich,  Germany

Mime
View raw message