apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wilfredo Sánchez Vega <wsanc...@wsanchez.net>
Subject Re: apr_filepath_encoding on Darwin
Date Mon, 06 Aug 2007 23:10:23 GMT
   +1

	-wsv

On Aug 5, 2007, at 5:51 AM, Erik Huelsmann wrote:

>>> - if Darwin has a configurable locale, does *not* set this up by
>>> default
>>> such that nl_langinfo(CODESET) returns UTF-8, but does by policy
>>> require
>>> filenames in UTF-8, regardless of locale, I would agree with  
>>> changing
>>> apr_filepath_encoding as Erik proposed.  That is the case?
>>
>>   I don't know what the BSD locale system (nl_langinfo , whatever)
>> does in Darwin; I've never worked with it.  I only know that for file
>> names, we tell developers to use UTF-8.
>>
>>        -wsv
>
> I'd like to conclude this thread then by supplying a patch which
> applies equally to trunk and 0.9.x with patch -p1, to return UTF8
> paths on Darwin.
>
> Note that I wasn't able to test the change myself, as I don't have
> access to Darwin, but the code change is trivial. (I just wonder if I
> got the #if-s right.)
>
> Bye,
>
> Erik.
>
> (I attached the patch because Google often munges them, but if you
> want, I can supply it inline too.)
> <apr-trunk-darwin-utf8-filepaths.patch>

—
Wilfredo Sánchez - wsanchez@wsanchez.net




Mime
View raw message