apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davi Arnaut <d...@haxent.com.br>
Subject Re: svn commit: r555640 - /apr/apr/trunk/include/apr_ring.h
Date Thu, 12 Jul 2007 19:50:49 GMT
Paul Querna wrote:
> davi@apache.org wrote:
>> Author: davi
>> Date: Thu Jul 12 07:23:13 2007
>> New Revision: 555640
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=555640
>> Log:
>> Add helper macros for ring walking (APR_RING_FOREACH and APR_RING_FOREACH_SAFE).
> 
> I'm not sure if we want to keep these or not.
> 
> I don't have anything wrong with them, but didn't we remove the _FOREACH
> macros from brigades in 0.9->1.x?

Sorry, I didn't saw the old commits that removed the macros.

> It seems odd to remove them from one API, and to add them here....
> 
> Thoughts?
> 

IMHO, the reasoning behind the removal was weak. We shouldn't penalize
everyone for the sake of the few that get it wrong.

--
Davi Arnaut

Mime
View raw message