apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davi Arnaut <d...@haxent.com.br>
Subject Re: svn commit: r553679 - /apr/apr/trunk/strings/apr_snprintf.c
Date Mon, 09 Jul 2007 13:22:54 GMT
Martin Kraemer wrote:
> On Fri, Jul 06, 2007 at 08:51:38AM -0300, Davi Arnaut wrote:
>>> Also the *INT32_MAX types are from C99 stdint.h which might not be present.
>> Good catch, I guess we could use *INT_MAX. This begs the question: why
>> don't we have APR_*INT32_MIN/MAX?
> 
> Good point. Especially for the apr-defined int types, there should
> also be a <type>_MAX define.
> 
> I'm +1  for adding them -- as at the moment, on FreeBSD-4.x I cannot compile apr:
> 
> /usr/local/bin/bash /home/martin/apachen/X/httpd-2.3/srclib/apr/libtool --silent --mode=compile
gcc -g -O2 -Wall   -DHAVE_CONFIG_H -D_THREAD_SAFE -D_REENTRANT   -I./include -I/home/martin/apachen/X/httpd-2.3/srclib/apr/include/arch/unix
-I./include/arch/unix -I/home/martin/apachen/X/httpd-2.3/srclib/apr/include  -o strings/apr_snprintf.lo
-c strings/apr_snprintf.c && touch strings/apr_snprintf.lo
> strings/apr_snprintf.c: In function `conv_10_quad':
> strings/apr_snprintf.c:384: `UINT32_MAX' undeclared (first use in this function)
> strings/apr_snprintf.c:384: (Each undeclared identifier is reported only once
> strings/apr_snprintf.c:384: for each function it appears in.)
> strings/apr_snprintf.c:385: `INT32_MAX' undeclared (first use in this function)
> strings/apr_snprintf.c:385: `INT32_MIN' undeclared (first use in this function)
> strings/apr_snprintf.c: In function `conv_p2_quad':
> strings/apr_snprintf.c:643: `UINT32_MAX' undeclared (first use in this function)
> Make[1]: *** [strings/apr_snprintf.lo] Error 1
> Make[1]: Leaving directory `/home/martin/apachen/X/httpd-2.3/srclib/apr'
> 
> and there's no <stdint.h>, and neither <inttypes.h> nor <limits.h>
> provide something like *INT32_MAX.
> 

Could you try the attached patch? Thanks.

--
Davi Arnaut


Mime
View raw message