apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r560688 - /apr/apr-util/trunk/build/apu-conf.m4
Date Sun, 29 Jul 2007 10:14:13 GMT
On Sun, Jul 29, 2007 at 07:14:51AM -0000, Justin Erenkrantz wrote:
> Author: jerenkrantz
> Date: Sun Jul 29 00:14:50 2007
> New Revision: 560688
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=560688
> Log:
> Fix up r493791 by properly exporting library path when --with-expat specified.
> 
> * build/apu-conf.m4
>   (APU_SYSTEM_EXPAT): If it lives in /usr/local/lib, set APRUTIL_LDFLAGS.
>   (APU_FIND_EXPAT): Properly save/restore CPPFLAGS/LDFLAGS and set
>   APRUTIL_LDFLAGS when withval is set.

Hmm, why the save/restore of CPPFLAGS/LDFLAGS?  This is only necessary 
when there is some failure case where the changes made will not persist 
until build time, so should not affect subsequent tests.  For cases like 
e.g. --with-expat=/path, the path modifications will persist to build 
time, so should be left as-is; they have a legitimate effect on 
subsequent tests.

joe

Mime
View raw message