apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r553679 - /apr/apr/trunk/strings/apr_snprintf.c
Date Fri, 06 Jul 2007 10:41:27 GMT
On Fri, Jul 06, 2007 at 12:46:53AM -0000, Davi Arnaut wrote:
> Author: davi
> Date: Thu Jul  5 17:46:53 2007
> New Revision: 553679
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=553679
> Log:
> Convert wide* types to the portable apr types. Conversion table:
> 
> wide_int        apr_int32_t
> u_wide_int      apr_uint32_t
> widest_int      apr_int64_t
> u_widest_int    apr_uint64_t
> bool_int        int

Are these wide_int -> int32_t changes correct?  wide_int was long before 
and is now always 32-bit.  Also the *INT32_MAX types are from C99 
stdint.h which might not be present.

...
>                      if (var_type == IS_LONG)
> -                        ui_num = (u_wide_int) va_arg(ap, u_wide_int);
> +                        ui_num = va_arg(ap, apr_uint32_t);


Mime
View raw message