Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (herse.apache.org: local policy)
Message-ID: <468017FA.7010805@rowe-clan.net>
Date: Mon, 25 Jun 2007 14:31:06 -0500
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 1.5.0.12 (X11/20070530)
MIME-Version: 1.0
To: Marshall Powers <mpowers@appsecinc.com>
CC: dev@apr.apache.org, 'Log4CXX User' <log4cxx-user@logging.apache.org>
Subject: Re: Problem with iconv charsets...
References: <1182787731.27898.ezmlm@apr.apache.org>
 <000d01c7b744$c89e86c0$2c01a8c0@nycapt35k.com>
 <467FEE24.4000809@rowe-clan.net>
 <000e01c7b748$b0483900$2c01a8c0@nycapt35k.com>
In-Reply-To: <000e01c7b748$b0483900$2c01a8c0@nycapt35k.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Marshall Powers wrote:
> The string literal "ISO-8859-1" appears in APR and log4cxx source code. For
> example, from apr-1.2.7/misc/unix/charset.c:
> 
> APR_DECLARE(const char*) apr_os_default_encoding (apr_pool_t *pool)
> {
> #ifdef __MVS__
> #    ifdef __CODESET__
>         return __CODESET__;
> #    else
>         return "IBM-1047";
> #    endif
> #endif
> 
>     if ('}' == 0xD0) {
>         return "IBM-1047";
>     }
> 
>     if ('{' == 0xFB) {
>         return "EDF04";
>     }
> 
>     if ('A' == 0xC1) {
>         return "EBCDIC"; /* not useful */
>     }
> 
>     if ('A' == 0x41) {
>         return "ISO-8859-1"; /* not necessarily true */
>     }
> 
> Are these files generated by configure scripts/ant build files? It doesn't
> seem like they are...

Nope.  That is raw, native hackery in an effort not to think through the
problem set.  As with all APR code, patches are welcome.

Some thoughts;

 * At run-time this should probably be determined by parsing first the
   LC_CTYPE, or LC_ALL in it's absense, or the fallback to the LANG
   envvar if neither LC_ variable is defined.  The codepage follows
   the period, e.g. LANG=en_US.UTF-8 would be parsed as 'UTF-8'.

 * It's reasonably trivial, if iconv is present, to validate the -fallback-
   charset name against iconv within autoconf, presuming this even should
   be ISO-8859-1

Comments?