From dev-return-18364-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue May 01 15:21:44 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 19412 invoked from network); 1 May 2007 15:21:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 May 2007 15:21:42 -0000 Received: (qmail 40364 invoked by uid 500); 1 May 2007 15:21:47 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 40319 invoked by uid 500); 1 May 2007 15:21:47 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 40307 invoked by uid 99); 1 May 2007 15:21:47 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2007 08:21:47 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of ehuels@gmail.com designates 64.233.184.233 as permitted sender) Received: from [64.233.184.233] (HELO wr-out-0506.google.com) (64.233.184.233) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2007 08:21:39 -0700 Received: by wr-out-0506.google.com with SMTP id 70so1782235wra for ; Tue, 01 May 2007 08:21:18 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=GqnB6YCtEx3MdtfImH+53R2ojcXKKNQuoKKsTYl7zK9ZDzg1lIBwN5Dkd4LPIaCICSKmuSHgeoDXUzYvEsGrax2AwTCAfD2JM3Tz0Vxn/WqwNRehe5iavlPXrCBJkMvhK7sWrPvMm/V0c0ftk2d5ZTAef6FUsflSKuLeflBpJcU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=exvwkd8Gz+nTSctjiUVZCNJw4MIddQ/KfUfPTyQ39eLY7htAp04gVhbzX5oUY5Vz0MTigaXyjECHRCtl68JxBwPUKTrLP/XefGY13CxT8P0mzHGOcxTafl3a+ZrgpMcc1PT/USOQsg9NiBaosIXXoifMCAFsc+7HnSvykm9Wwf4= Received: by 10.114.210.2 with SMTP id i2mr578852wag.1178032875361; Tue, 01 May 2007 08:21:15 -0700 (PDT) Received: by 10.115.78.3 with HTTP; Tue, 1 May 2007 08:21:15 -0700 (PDT) Message-ID: Date: Tue, 1 May 2007 17:21:15 +0200 From: "Erik Huelsmann" To: "Curt Arnold" Subject: Re: apr-util/misc/apr_thread_pool.c compile failure in VC6 Cc: "APR Developer List" In-Reply-To: <12C5410F-F545-43EA-9286-CDB023E5A0D2@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <12C5410F-F545-43EA-9286-CDB023E5A0D2@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org On 5/1/07, Curt Arnold wrote: > apr_thread_pool.c did not appear in the VC6 project in 1.2.8, but has > been added in the SVN HEAD and it fails to compile under VC6 in debug > mode due to a C++ style variable declaration. The following change > fixes the compile error. Shouldn't the moved variable be in conditionals too? This will introduce a warning when *not* compiling with NDEBUG, right? bye, Erik. > Index: apr_thread_pool.c > =================================================================== > --- apr_thread_pool.c (revision 534087) > +++ apr_thread_pool.c (working copy) > @@ -595,6 +595,7 @@ > > static void wait_on_busy_threads(apr_thread_pool_t * me, void *owner) > { > + apr_os_thread_t *os_thread; > struct apr_thread_list_elt *elt; > apr_thread_mutex_lock(me->lock); > elt = APR_RING_FIRST(me->busy_thds); > @@ -605,7 +606,6 @@ > } > #ifndef NDEBUG > /* make sure the thread is not the one calling tasks_cancel */ > - apr_os_thread_t *os_thread; > apr_os_thread_get(&os_thread, elt->thd); > #ifdef WIN32 > /* hack for apr win32 bug */ >