apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: several patches for Solaris >= 10
Date Wed, 21 Mar 2007 01:04:51 GMT
On Tue, Mar 20, 2007 at 07:53:16PM -0400, Stefan Teleman wrote:
> Please find attached a series of patches for Solaris >= 10, based on 2.2.4 
> code.

We already added the solaris atomic API support to trunk, pretty long
ago at this point.

http://svn.apache.org/repos/asf/apr/apr/trunk/atomic/unix/apr_atomic.c

Are yours better? (quite possible)

Also, why do you undefine the generics atomics defines? they exist
for a reason!

Your patch also seems to be a diff against a httpd source tree, and
includes httpd-specific code. This is dev@apr, please use it only for
APR code, and it's best to submit patches against trunk , *not* whatever
httpd happens to ship :-)

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message