apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Teleman" <stefan.tele...@gmail.com>
Subject Re: several patches for Solaris >= 10
Date Wed, 21 Mar 2007 01:32:32 GMT
On 3/20/07, Colm MacCarthaigh <colm@stdlib.net> wrote:

> Also, why do you undefine the generics atomics defines? they exist
> for a reason!

On 3/20/07, Colm MacCarthaigh <colm@stdlib.net> wrote:

> Also, why do you undefine the generics atomics defines? they exist
> for a reason!

#if defined(SOLARIS2) && ((SOLARIS2 + 0) >= 10)
#include <atomic.h>
#if defined(USE_GENERIC_ATOMICS)
#undef USE_GENERIC_ATOMICS
#endif

If i am in Solaris >= 10 and i have the Solaris atomics, do i want to
still need the generic atomics ?

> Your patch also seems to be a diff against a httpd source tree, and
> includes httpd-specific code. This is dev@apr, please use it only for
> APR code, and it's best to submit patches against trunk , *not* whatever
> httpd happens to ship :-)

yes it is against 2.2.4.

when i sent the original patch for the atomics to httpd@,  a couple
months ago, i was told to send it to apr@, because "this was an apr
patch".

;-)

--Stefan

-- 
Stefan Teleman
KDE e.V.
stefan.teleman@gmail.com

Mime
View raw message