Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (herse.apache.org: local policy)
Message-ID: <45E5E488.9040602@rowe-clan.net>
Date: Wed, 28 Feb 2007 14:22:32 -0600
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Thunderbird 1.5.0.9 (X11/20070102)
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: svn commit: r512557 - in /apr/apr-util/trunk: CHANGES
 dbm/sdbm/sdbm.c
References: <20070228014733.1D0C61A981A@eris.apache.org>
 <45E4E908.8000804@rowe-clan.net>
 <5c902b9e0702272028x35473377uac613c78a9ce1f1a@mail.gmail.com>
 <45E542EB.2050809@rowe-clan.net>
 <5c902b9e0702280112x25d6d5afy294c0119b46353b9@mail.gmail.com>
 <20070228104507.GA23630@redhat.com>
 <5c902b9e0702280829t30101d48o137300f56f345962@mail.gmail.com>
 <20070228165144.GA31587@redhat.com>
In-Reply-To: <20070228165144.GA31587@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Joe Orton wrote:
> On Wed, Feb 28, 2007 at 08:29:10AM -0800, Justin Erenkrantz wrote:
>> The performance implications of not doing buffered reads just *kills*
>> our server - so we need to do something and adding buffering lessens
>> the load quite dramatically.  In our situation, we couldn't care less
>> about modifying the file - we only care to optimize the read-only case
>> - and I believe that code is just fine and stable.  Though I guess I'd
>> prefer we fix the problems with buffering if they do exist.
>>
>> Would you be concerned if we added APR_BUFFERED to APR_DBM_DBMODE_RO
>> for sdbm?  -- justin
> 
> No, that sounds fine, or just moving your change up inside the !(flags & 
> APR_WRITE) condition so that all apr_sdbm_* users benefit equally.

-1 on this change unless you compare the datum you do hit that it's still
the record you expected.  If we hit the wrong record (our copy of the
buffered index page mismatched the found page) we must flush and retry
once.  If the retry fails, then error out.

Bill