From dev-return-18072-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Feb 20 08:45:25 2007 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 72048 invoked from network); 20 Feb 2007 08:45:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Feb 2007 08:45:24 -0000 Received: (qmail 55978 invoked by uid 500); 20 Feb 2007 08:45:30 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 55924 invoked by uid 500); 20 Feb 2007 08:45:30 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 55913 invoked by uid 99); 20 Feb 2007 08:45:30 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2007 00:45:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2007 00:45:20 -0800 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l1K8ixSB019054 for ; Tue, 20 Feb 2007 03:44:59 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l1K8iwoV020295 for ; Tue, 20 Feb 2007 03:44:58 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.8/8.13.7) with ESMTP id l1K8iv8x020135 for ; Tue, 20 Feb 2007 08:44:57 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.8/8.13.8/Submit) id l1K8ivrH020134 for dev@apr.apache.org; Tue, 20 Feb 2007 08:44:57 GMT Date: Tue, 20 Feb 2007 08:44:57 +0000 From: Joe Orton To: dev@apr.apache.org Subject: Re: svn commit: r509038 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c test/testpoll.c Message-ID: <20070220084457.GA19852@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <20070219003102.C47E01A981A@eris.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20070219003102.C47E01A981A@eris.apache.org> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Feb 19, 2007 at 12:31:02AM -0000, Paul Querna wrote: > Author: pquerna > Date: Sun Feb 18 16:31:01 2007 > New Revision: 509038 > > URL: http://svn.apache.org/viewvc?view=rev&rev=509038 > Log: > Add the apr_pollcb API. > > This mostly sitting in the pollcb-dev branch for several months at: > > > The version in this commit has small improvements, and an KQueue backend. > > This will likely break trunk for operating systems were we only have > select|poll, so we will need to add some autoconf foo to define a > HAVE_APR_POLLCB unless someone can implement apr_pollcb for all > platforms. And yea, verily, the build broke! Does this really need autoconf help? It just needs some ENOTIMPL stubs #if !defined(HAVE_KQUEUE) && !defined(HAVE_etc etc somewhere? Also a significant lack of API documentation here! joe