apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r512557 - in /apr/apr-util/trunk: CHANGES dbm/sdbm/sdbm.c
Date Wed, 28 Feb 2007 02:29:28 GMT
Any thread safety implications here?  If the data isn't refreshed
between writes, it seems this could be a major hassle.



jerenkrantz@apache.org wrote:
> Author: jerenkrantz
> Date: Tue Feb 27 17:47:32 2007
> New Revision: 512557
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=512557
> Log:
> Use buffered I/O with SDBM.
> 
> Submitted by: Joe Schaefer
> Reviewed by: Justin Erenkrantz
> 
> Modified:
>     apr/apr-util/trunk/CHANGES
>     apr/apr-util/trunk/dbm/sdbm/sdbm.c
> 
> Modified: apr/apr-util/trunk/CHANGES
> URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/CHANGES?view=diff&rev=512557&r1=512556&r2=512557
> ==============================================================================
> --- apr/apr-util/trunk/CHANGES (original)
> +++ apr/apr-util/trunk/CHANGES Tue Feb 27 17:47:32 2007
> @@ -1,5 +1,7 @@
>  Changes with APR-util 1.3.0
>  
> +  *) Use buffered I/O with SDBM.  [Joe Schaefer]
> +
>    *) Unify parsing of prepared statements and add binary argument functions
>       to DBD [Bojan Smojver with help from many on the APR list]
>  
> 
> Modified: apr/apr-util/trunk/dbm/sdbm/sdbm.c
> URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/dbm/sdbm/sdbm.c?view=diff&rev=512557&r1=512556&r2=512557
> ==============================================================================
> --- apr/apr-util/trunk/dbm/sdbm/sdbm.c (original)
> +++ apr/apr-util/trunk/dbm/sdbm/sdbm.c Tue Feb 27 17:47:32 2007
> @@ -120,7 +120,7 @@
>          flags &= ~APR_SHARELOCK;
>      }
>  
> -    flags |= APR_BINARY | APR_READ;
> +    flags |= APR_BINARY | APR_READ | APR_BUFFERED;
>  
>      /*
>       * open the files in sequence, and stat the dirfile.
> 
> 
> 
> 



Mime
View raw message