apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r509038 - in /apr/apr/trunk: CHANGES include/apr_poll.h poll/unix/epoll.c poll/unix/kqueue.c test/testpoll.c
Date Tue, 20 Feb 2007 17:02:41 GMT
Paul Querna wrote:
> Joe Orton wrote:
>> On Mon, Feb 19, 2007 at 12:31:02AM -0000, Paul Querna wrote:
>>> Author: pquerna
>>> Date: Sun Feb 18 16:31:01 2007
>>> New Revision: 509038
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=509038
>>> Log:
>>> Add the apr_pollcb API.
>>>
>>> This mostly sitting in the pollcb-dev branch for several months at:
>>>    <https://svn.apache.org/repos/asf/apr/apr/branches/pollcb-dev/>
>>>
>>> The version in this commit has small improvements, and an KQueue backend.
>>>
>>> This will likely break trunk for operating systems were we only have 
>>> select|poll, so we will need to add some autoconf foo to define a 
>>> HAVE_APR_POLLCB unless someone can implement apr_pollcb for all 
>>> platforms.
>> And yea, verily, the build broke!  Does this really need autoconf help?  
>> It just needs some ENOTIMPL stubs #if !defined(HAVE_KQUEUE) && 
>> !defined(HAVE_etc etc somewhere?
> 
> Sure, I can add stubs with ENOTIMPL if thats the way people want to go :-)

r509637 adds stubs for poll and select.

>> Also a significant lack of API documentation here!
> 
> Yup, Its on my todo to add the API docs.... but at least there was one
> test case, right?

r509647 adds doxygen comments and docs for the pollcb functions.
(Not really happy with all of the remarks, need to write something
explaining why you would want to use it over apr_pollset*).

-Paul




Mime
View raw message