Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 15462 invoked from network); 3 Jan 2007 19:37:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jan 2007 19:37:55 -0000 Received: (qmail 42926 invoked by uid 500); 3 Jan 2007 19:38:00 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 42882 invoked by uid 500); 3 Jan 2007 19:38:00 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 42870 invoked by uid 99); 3 Jan 2007 19:38:00 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 11:38:00 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of trawick@gmail.com designates 64.233.182.184 as permitted sender) Received: from [64.233.182.184] (HELO nf-out-0910.google.com) (64.233.182.184) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 11:37:51 -0800 Received: by nf-out-0910.google.com with SMTP id x37so7256229nfc for ; Wed, 03 Jan 2007 11:37:30 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=G70cxFrK+m2x1t+wfdcVhNyCY9R/hJP5C4NSq0G9dVvnMlsoR0B0sL6ThoZKjm6wWrk/bBRAgxIz86wiIUQc5EitK1EptjYDNnULEQbs9QtF4uL4lE1g7ZF5bkpqeUEaflcu/6G4XLGu03v5hje9DnYJxgn/+Bttz47RM8NaDqc= Received: by 10.82.118.2 with SMTP id q2mr1852242buc.1167853049987; Wed, 03 Jan 2007 11:37:29 -0800 (PST) Received: by 10.82.159.13 with HTTP; Wed, 3 Jan 2007 11:37:29 -0800 (PST) Message-ID: Date: Wed, 3 Jan 2007 14:37:29 -0500 From: "Jeff Trawick" To: dev@apr.apache.org Subject: Re: [PATCH] Optimized MD5 implementation from OpenSSL In-Reply-To: <5c902b9e0701030829w5457ac81hd818370259de2b49@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070102220102.GB3226@bourbon.ics.uci.edu> <20070103103050.GA10268@redhat.com> <5c902b9e0701030829w5457ac81hd818370259de2b49@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org On 1/3/07, Justin Erenkrantz wrote: > On 1/3/07, Joe Orton wrote: > > 1. is having an ENOTIMPL _set_xlate really an excusable regression? > > Yes. We already do that for !APR_HAS_XLATE case, so callers need to > handle that anyway. assert(there's no necessary initialization for _set_xlate to perform when using the OpenSSL MD5 implementation), so shouldn't it be an empty function that returns APR_SUCCESS? If the assertion is not known to be correct then we need to research a bit further, with the goal that we either return APR_SUCCESS (no initialization needed) or avoid the use of OpenSSL MD5 at build time when we know the _set_xlate() must be called. Make sense?