Return-Path: 
 <dev-return-17800-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 94262 invoked from network); 3 Jan 2007 18:08:12 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 3 Jan 2007 18:08:12 -0000
Received: (qmail 83671 invoked by uid 500); 3 Jan 2007 18:08:17 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 83624 invoked by uid 500); 3 Jan 2007 18:08:17 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Id: <dev.apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 83613 invoked by uid 99); 3 Jan 2007 18:08:17 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 10:08:17 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: local policy)
Received: from [207.229.186.130] (HELO nihul.cartissolutions.com)
 (207.229.186.130)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Jan 2007 10:07:52 -0800
Received: (qmail 15627 invoked from network); 3 Jan 2007 18:14:04 -0000
Received: from unknown (HELO ?192.168.200.194?) (192.168.200.194)
  by nihul.cartissolutions.com with SMTP; 3 Jan 2007 18:14:04 -0000
Message-ID: <459BF0DC.20600@cartissolutions.com>
Date: Wed, 03 Jan 2007 12:07:24 -0600
From: Yossi Neiman <freeswitch@cartissolutions.com>
Organization: Cartis Solutions, Inc.
User-Agent: Thunderbird 1.5.0.7 (X11/20060919)
MIME-Version: 1.0
To: Ryan Phillips <ryan-apr@trolocsis.com>
CC: dev@apr.apache.org
Subject: Re: apr_queue_t enhancement - please review for inclusion
References: <4594B4C6.5050402@cartissolutions.com>
 <20070102232702.GA85170@zeus.kimaker.com>
In-Reply-To: <20070102232702.GA85170@zeus.kimaker.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

See below.

Ryan Phillips wrote:
> Yossi Neiman <freeswitch@cartissolutions.com> said:
<snip snip>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=41254
>>
> 
> I would find this patch useful.  One problem I see with the patch is
> that 'rv' is used uninitialized a few times:
> 
> {
>     apr_status_t rv;
> 
>     if (!queue->terminated) {
>         ...
>     }
> 
>     return rv;
> }
> 
> -ryan

How right you are.  I have fixed this error and have posted updated 
patches to the bugtracker (under the same issue of course).  I'm glad 
that this is of interest to you.

-Yossi