apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Phillips <ryan-...@trolocsis.com>
Subject Re: apr_queue_t enhancement - please review for inclusion
Date Tue, 02 Jan 2007 23:27:02 GMT
Yossi Neiman <freeswitch@cartissolutions.com> said:
> Hi everybody,
> 
> I worked up some enhancements to the apr_queue.c/h files, basically 
> allowing manually blocking of push and/or pop, and also providing a 
> function that will block until the queue is empty.  I've already used 
> this in some code that I have written for FreeSWITCH to allow for a safe 
> reload of the configuration file for my module.  Hopefully you will 
> think that this is useful for the rest of the world to be able to use.  
> Patches included in the bug.
> 
> http://issues.apache.org/bugzilla/show_bug.cgi?id=41254
> 

I would find this patch useful.  One problem I see with the patch is
that 'rv' is used uninitialized a few times:

{
    apr_status_t rv;

    if (!queue->terminated) {
        ...
    }

    return rv;
}

-ryan

Mime
View raw message