Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 11870 invoked from network); 27 Nov 2006 12:54:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Nov 2006 12:54:36 -0000 Received: (qmail 2581 invoked by uid 500); 27 Nov 2006 12:54:46 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 2207 invoked by uid 500); 27 Nov 2006 12:54:44 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 2195 invoked by uid 99); 27 Nov 2006 12:54:44 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2006 04:54:44 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2006 04:54:32 -0800 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id kARCsAKt017822 for ; Mon, 27 Nov 2006 07:54:10 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id kARCs9vc015740 for ; Mon, 27 Nov 2006 07:54:10 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.7/8.13.7) with ESMTP id kARCs8sh019376 for ; Mon, 27 Nov 2006 12:54:08 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.7/8.13.7/Submit) id kARCs6NH019371 for dev@apr.apache.org; Mon, 27 Nov 2006 12:54:06 GMT X-Authentication-Warning: radish.cambridge.redhat.com: jorton set sender to jorton@redhat.com using -f Date: Mon, 27 Nov 2006 12:54:05 +0000 From: Joe Orton To: dev@apr.apache.org Subject: Re: [PATCH] we need to init _unknown? Message-ID: <20061127125405.GA18933@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <4565CF0E.4080100@rowe-clan.net> <4565DF3A.6060905@rowe-clan.net> <20061124091315.GA15878@redhat.com> <456A81F2.5010906@rowe-clan.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <456A81F2.5010906@rowe-clan.net> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Nov 27, 2006 at 12:13:06AM -0600, William Rowe wrote: > Joe Orton wrote: > > (The test_get_addr test was to check for a ->remote_addr_unknown > > handling bug alone, FWIW: PR 32737) > > Right - and it erroneously invokes connect against 0.0.0.0 no matter which > way I patch this. We need to determine that connect-to 0.0.0.0 is portable > behavior and emulate, correct the patch to connect to a non-ephemeral addr, > or revert the test. I've changed it to use 127.0.0.1 on the trunk; does that help? > And we need to roll a tarball - this is getting silly. But I'm not rolling > with a borked test. The test has been in 1.2.x since September 2005 - did something change since then? Regards, joe