apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] we need to init _unknown?
Date Mon, 27 Nov 2006 06:13:06 GMT
Joe Orton wrote:
> (The test_get_addr test was to check for a ->remote_addr_unknown 
> handling bug alone, FWIW: PR 32737)

Right - and it erroneously invokes connect against no matter which
way I patch this.  We need to determine that connect-to is portable
behavior and emulate, correct the patch to connect to a non-ephemeral addr,
or revert the test.

And we need to roll a tarball - this is getting silly.  But I'm not rolling
with a borked test.

> The use of the term "interface" in the comments, code and API is totally 
> confusing :( It's used to mean variously "socket endpoint" and 
> "address", and never actually anything to do with a network interface, 
> except maybe in the multicast code.

Yes - 2.0 deserves a nice refactoring - that much I'm convinced of :)

View raw message