apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: Test suite and out of tree builds
Date Wed, 08 Nov 2006 09:00:22 GMT
Tollef Fog Heen wrote:
> Hi,
> 
> currently, the test suite fails horribly in testfileinfo,
> testfilecopy, testfile, testfnmatch, testmmap if you build with srcdir
> different from builddir.
> 
> The attached patch fixes this by prepending APR_SRCDIR in the relevant
> places as well as defining APR_SRCDIR in test/.  The test suite works
> for me in both in-tree and out-of-tree builds with the patch applied.

This is very cool!  Thank you - I've been wanting to solve this for a long
while and like your approach.

However, can you validate before I begin reviewing that you don't actually
open anything in the SRCDIR for write?

One rule of vpath builds - the sources tree should always be nonvolatile.

Bill

Mime
View raw message