apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] we need to init _unknown?
Date Fri, 24 Nov 2006 09:13:15 GMT
On Thu, Nov 23, 2006 at 11:49:46AM -0600, William Rowe wrote:
> William A. Rowe, Jr. wrote:
> > 
> > It also appears that sockets.c in MANY cases just fails to initialize
> > (local|remote)_interface_unknown, unless I'm imagining things.
> 
> Am I blinking insane or was this completely broken?

You are setting some "->local_addr_unknown" in the patch which doesn't 
exist.  Even if this did /addr/interface/ then the patch doesn't look 
obviously correct for the Unix code: apr_socket_bind() does not *unset* 
->local_interface_unknown so maybe assumes it was unset already.  What 
cases does this look broken for?

(The test_get_addr test was to check for a ->remote_addr_unknown 
handling bug alone, FWIW: PR 32737)

The use of the term "interface" in the comments, code and API is totally 
confusing :( It's used to mean variously "socket endpoint" and 
"address", and never actually anything to do with a network interface, 
except maybe in the multicast code.

joe

Mime
View raw message