apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Jen <henry...@ztune.net>
Subject Re: [PATCH] apr_threadpool
Date Tue, 26 Sep 2006 23:04:20 GMT

Attached is an updated patch, which include following changes since last 

1. The check for current thread not to be the owner include a hack for 
the Win32 bug where apr_os_thread_current is returning a HANDLE instead 
of a pointer to HANDLE as apr_os_thread_get does.

2. Remove the copyright notice and apply source header to be conforming 
with "Source File Headers for Code Developed at the ASF" section in [1]. 
Our legal would like to see the copyright notice in NOTICE file per 
option 1.b. But I am not sure how APR would like to deal with it.


[1] http://www.apache.org/legal/src-headers.html

William A. Rowe, Jr. wrote:
> I'm +1 on adopting this in trunk so that the developers can spend some
> time with the API, and we can begin duking out the details.
> I suspect it could use a bit of tweaking, but it's easier to do that in
> svn - the email thread has already yielded a cleaner API.
> Henry Jen wrote:
>> Hi,
>> Attached please find the latest patch to support thread_pool(the last
>> one had a bug and cannot be merged cleanly), which has two enhancement
>> from earlier patch:
>> 1. Ownership support: Now when submit a task to the thread pool, an
>> owner identity can be specified. Which can be used to remove all tasks
>> belongs to that owner afterwards.
>> 2. Timer: It is possible to schedule a task to be executed after a
>> certain time interval. By doing another schedule within a task, that is
>> basically a timer. Noted that scheduled tasks are with highest priority,
>> and due tasks are always picked up first.
>> Comments are always welcome, and hopefully soon this can be committed.
>> Cheers,
>> Henry

View raw message