apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] apr_atomic_cas broken in 0.9.x
Date Mon, 25 Sep 2006 17:30:00 GMT
Philip Martin wrote:
> Philip Martin <philip@codematters.co.uk> writes:
> 
>> Port some of the atomic code from 1.2.x to 0.9.x, in particular make
>> mutex operations that fail cause an abort and make the generic C
>> implementation of apr_atomic_cas work on 64 bit platforms.
> 
> A less radical change to the code is simply to truncate the 64 bit
> values and rely on the application not to need those bits.  This
> should be enough to fix Subversion which only uses small +ve integers.

Thanks Filip!

This sure points out the need for 64 bit atomics but the compromise looks
great to solve the existing issue.

Thanks to Garrett for jumping on this patch.

Mime
View raw message