apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r442492 - /apr/apr/branches/1.2.x/network_io/unix/sockets.c
Date Wed, 20 Sep 2006 19:04:18 GMT
Joe Orton wrote:
> If the API guarantee is "may allocate memory on failure" then the fix is 
> bad and should be reverted; the caller will have to do the 
> create/destroy dance anyway so it's needless overhead whether large or 
> small.
> If the API guarantee is "will not allocate memory on failure" then 
> clearly this fix is necessary.  I think this option makes more sense.

Ok - reading Mladen's and your comments, I'll agree the extra copy is
warrented, let's proceed on your plan...

 * revert the original patch from 0.9, 1.2 branches for the moment
 * let this patch settle a bit
 * backport correct/complete patch

Or did I misunderstand you?


View raw message