apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Jen <henry...@ztune.net>
Subject Re: Win32 apr_os_thread_get and apr_os_thread_put has mismatch type
Date Thu, 07 Sep 2006 00:22:54 GMT
William A. Rowe, Jr. wrote:
> Henry Jen wrote:
>> -    *thethd = thd->td;
>> +    *thethd = &thd->td;
> 
> -1 - I don't know if you noticed but you just returned to the caller
> the address of the HANDLE in the thd object, meaning that it won't
> outlive the destruction of the thd.
> 
> 

Good point. What's your suggestion?

The patch is bad, but it won't change the fact this is a bug.

Unfortunately, I don't see a easy way out top off my head.

Cheers,
Henry


Mime
View raw message